-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: [VAULT-12979] Dashboard Landing Page #21057
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiannaquach
changed the title
UI: VAULT-16941 Initial dashboard route set up (#21051)
UI: Landing Page Dashboard
Jun 7, 2023
VioletHynes
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Jul 6, 2023
kiannaquach
changed the title
UI: Dashboard Landing Page
UI: [VAULT-12979] Dashboard Landing Page
Aug 24, 2023
hashishaw
reviewed
Aug 24, 2023
hashishaw
reviewed
Aug 24, 2023
hashishaw
reviewed
Aug 24, 2023
hashishaw
reviewed
Aug 24, 2023
hashishaw
reviewed
Aug 24, 2023
hashishaw
reviewed
Aug 24, 2023
hashishaw
reviewed
Aug 24, 2023
hashishaw
reviewed
Aug 24, 2023
hashishaw
reviewed
Aug 24, 2023
hashishaw
suggested changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🤩 Just a few cleanup items, and I think we need a bit of testing with community binary, and maybe with the HCP flag
hashishaw
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashboard
implement the TODO's once the localStorage work has startedno longer doing local storage thingsEnterprise:
Community: