Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: VAULT-17007 Add Dashboard to the sidenav #21058

Merged
merged 2 commits into from
Jun 7, 2023
Merged

UI: VAULT-17007 Add Dashboard to the sidenav #21058

merged 2 commits into from
Jun 7, 2023

Conversation

kiannaquach
Copy link
Contributor

Description

  • Add Dashboard to the side nav
Screenshot 2023-06-07 at 1 30 50 PM

@kiannaquach kiannaquach marked this pull request as ready for review June 7, 2023 20:31
@kiannaquach kiannaquach changed the title UI: VAULT-16941 Initial dashboard route set up (#21051) UI: VAULT-17007 Add Dashboard to the sidenav Jun 7, 2023
zofskeez
zofskeez reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the Vault logo in the top left of the sidebar is actually a link that we should now point to the dashboard route. It's in the Sidebar::Frame component and the HDS component is Hds::SideNav::Header::HomeLink

@kiannaquach
Copy link
Contributor Author

kiannaquach commented Jun 7, 2023 •
edited
Loading

@zofskeez Thanks for catching that! I just added a TODO since that logo nav item link is reliant on the localStorage work that will be done in another PR! Also added that as criteria in the ticket!

@zofskeez
Copy link
Contributor

zofskeez commented Jun 7, 2023 •
edited
Loading

that logo nav item link is reliant on the localStorage

Interesting so will the user be able to define which route will be their home view?

@kiannaquach
Copy link
Contributor Author

kiannaquach commented Jun 7, 2023 •
edited
Loading

In a sense, yes, they will be able to define their home route if the user wanted to opt into the new dashboard ui.

The user stories are:

If the user opts into the new dashboard ui by clicking "New Dashboard UI available" next to the Secret Engine, the logo should always link to the dashboard

If the user did not opt into the new dashboard ui, then the logo should always link to the secret engine list view

@zofskeez
Copy link
Contributor

zofskeez commented Jun 7, 2023

Gotcha that sounds good thanks for the context!

@kiannaquach kiannaquach merged commit 7f9f1ed into ui/landing-page-dashboard Jun 7, 2023
@kiannaquach kiannaquach deleted the ui/VAULT-17007/add-dashboard-to-sidenav branch June 7, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zofskeez zofskeez zofskeez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiannaquach @zofskeez