Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Revert URL encoding OCSP GET fix #18938 into release/1.12.x #19069

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Backport of Revert URL encoding OCSP GET fix #18938 into release/1.12.x #19069

merged 1 commit into from
Feb 8, 2023

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19037 to be assessed for backporting due to the inclusion of the label backport/1.12.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.

  • The fix within Apply URL encoding/unencoding to OCSP Get requests #18938 was incorrect and has caused a regression in OCSP GET request handling, as now the tests and program are double URL encoding the base64 + character when using Vault are becoming space characters within the handler and failing base64 decoding.
Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/stevendpclark/revert-18938/extremely-assuring-orca branch 2 times, most recently from 3ca41ba to ed15db4 Compare February 8, 2023 16:24
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@stevendpclark stevendpclark force-pushed the backport/stevendpclark/revert-18938/extremely-assuring-orca branch 2 times, most recently from 91c9411 to a2081c5 Compare February 8, 2023 17:37
@stevendpclark stevendpclark marked this pull request as ready for review February 8, 2023 17:43
@stevendpclark stevendpclark enabled auto-merge (squash) February 8, 2023 17:48
@stevendpclark stevendpclark self-assigned this Feb 8, 2023
@stevendpclark
Revert URL encoding OCSP GET fix #18938 (#19037)
ef6066f 
- This fix was incorrect as now the tests and program are double
   URL encoding the OCSP GET requests, so the base64 + characters
   when using Vault proper are becoming space characters.
@stevendpclark stevendpclark force-pushed the backport/stevendpclark/revert-18938/extremely-assuring-orca branch from a2081c5 to ef6066f Compare February 8, 2023 17:52
@stevendpclark stevendpclark merged commit 7763436 into release/1.12.x Feb 8, 2023
@stevendpclark stevendpclark deleted the backport/stevendpclark/revert-18938/extremely-assuring-orca branch February 8, 2023 18:39
@stevendpclark stevendpclark mentioned this pull request Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendpclark stevendpclark stevendpclark approved these changes

Assignees

@stevendpclark stevendpclark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hc-github-team-secure-vault-core @hashicorp-cla @stevendpclark