Revert URL encoding OCSP GET fix #18938 #19037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This fix was incorrect as now the tests and program are double URL encoding the OCSP GET requests, so the base64 + characters when using Vault proper are becoming space characters.
cipherboy
approved these changes
Feb 8, 2023
stevendpclark
added a commit
that referenced
this pull request
Feb 8, 2023
stevendpclark
added a commit
that referenced
this pull request
Feb 8, 2023
- This fix was incorrect as now the tests and program are double URL encoding the OCSP GET requests, so the base64 + characters when using Vault proper are becoming space characters. Co-authored-by: Steven Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+character when using Vault are becoming space characters within the handler and failing base64 decoding.