Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.11.x: Use host's uid in container's executor (#17729) #18167

Conversation

stevendpclark
Copy link
Contributor

Backport of #17729 for 1.11.x, I accidentally closed the original backport PR.

When copying data into the container, due to the id changes pointed out in the previous attempt, the container couldn't read this data.

By creating a new user in the container, matching the host's UID/GID, we can successfully copy data in/out of the container without worrying about differing UID/GIDs.

See also: #17658

Signed-off-by: Alexander Scheel [email protected]

Signed-off-by: Alexander Scheel [email protected]

When copying data into the container, due to the id changes pointed
out in the previous attempt, the container couldn't read this data.

By creating a new user in the container, matching the host's UID/GID, we
can successfully copy data in/out of the container without worrying
about differing UID/GIDs.

See also: #17658

Signed-off-by: Alexander Scheel <[email protected]>

Signed-off-by: Alexander Scheel <[email protected]>
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CONTAINER_ID changes might've come from another PR, but that's fine to squash them into this one.

@cipherboy cipherboy merged commit e91a025 into release/1.11.x Nov 30, 2022
@stevendpclark stevendpclark deleted the backport/cipherboy-fix-ci-for-real/heartily-just-snail branch November 30, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants