Add container's executor to host's group for copy #17729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
commented
Oct 28, 2022
cipherboy
force-pushed
the
cipherboy-fix-ci-for-real
branch
11 times, most recently
from
c782341 to
304985f
Compare
ncabatoff
reviewed
Oct 31, 2022
When copying data into the container, due to the id changes pointed out in the previous attempt, the container couldn't read this data. By creating a new user in the container, matching the host's UID/GID, we can successfully copy data in/out of the container without worrying about differing UID/GIDs. See also: #17658 Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
force-pushed
the
cipherboy-fix-ci-for-real
branch
from
304985f to
49d9b3b
Compare
ncabatoff
approved these changes
Oct 31, 2022
|
Thank you both! |
This was referenced Oct 31, 2022
This was referenced Nov 1, 2022
stevendpclark
pushed a commit
that referenced
this pull request
Nov 30, 2022
When copying data into the container, due to the id changes pointed out in the previous attempt, the container couldn't read this data. By creating a new user in the container, matching the host's UID/GID, we can successfully copy data in/out of the container without worrying about differing UID/GIDs. See also: #17658 Signed-off-by: Alexander Scheel <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
added a commit
that referenced
this pull request
Nov 30, 2022
When copying data into the container, due to the id changes pointed out in the previous attempt, the container couldn't read this data. By creating a new user in the container, matching the host's UID/GID, we can successfully copy data in/out of the container without worrying about differing UID/GIDs. See also: #17658 Signed-off-by: Alexander Scheel <[email protected]> Signed-off-by: Alexander Scheel <[email protected]> Signed-off-by: Alexander Scheel <[email protected]> Co-authored-by: Alexander Scheel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying data into the container, due to the id changes pointed out in the previous attempt, the container couldn't read this data.
By creating a new group inside the container, with the host's GID (if it doesn't already exist) and modifying the container user to also have this group, it should be able to access these files without requiring a chmod.
See also: #17658
Signed-off-by: Alexander Scheel <[email protected]>