Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add pkiCert example on agent template docs #15836

Merged
merged 1 commit into from
Jun 7, 2022
Merged

docs: add pkiCert example on agent template docs #15836

merged 1 commit into from
Jun 7, 2022

Conversation

calvn
Copy link
Contributor

@calvn calvn commented Jun 6, 2022 •
edited
Loading

PR to add an example for pkiCert in our docs which got introduced in consul-template v0.29.0 and slated for release in Vault 1.11.

Related to #15293

@calvn calvn added the docs label Jun 6, 2022
@calvn calvn added this to the 1.11.0 milestone Jun 6, 2022
@calvn calvn requested review from swenson and a team June 6, 2022 21:45
@calvn calvn requested a review from taoism4504 as a code owner June 6, 2022 21:45
swenson
swenson approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvn calvn merged commit 06c5635 into main Jun 7, 2022
Merged
@calvn calvn deleted the docs/agent-template-pkicert branch June 7, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoism4504 taoism4504 taoism4504 approved these changes

@swenson swenson swenson approved these changes

Assignees
No one assigned
Labels
docs pr/no-changelog
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@calvn @swenson @taoism4504