-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps for consul-template 0.29.0 #15293
Conversation
This requires bumping https://github.com/mitchellh/go-testing-interface. For this new version, we have to create a wrapper to convert the stdlib `testing.TB` interface to the `mitchellh/go-testing-interface` `T` interface, since it uses `Parallel()` now, which is not supported by `testing.TB`. This had to be added to a new package, `benchhelpers`, to avoid a circular dependency in `testhelpers`. We also have to *unbump* https://github.com/armon/go-metrics since updating it breaks our usage of https://github.com/google/go-metrics-stackdriver I verified that the new `pkiCert` template function works with agent injection using annotations like: ```yaml vault.hashicorp.com/agent-inject-secret-sample.crt: "pki/issue/example-dot-com" vault.hashicorp.com/agent-inject-template-sample.crt: | {{ pkiCert "pki/issue/example-dot-com" "common_name=foo.example.com" "ttl=1h" }} ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I just want to make sure I understand before hitting the green button. I also don't see any "unbump" for go-metrics, is that comment out of date now?
helper/benchhelpers/benchhelpers.go
Outdated
import ( | ||
"testing" | ||
|
||
testing2 "github.com/mitchellh/go-testing-interface" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing2 "github.com/mitchellh/go-testing-interface" | |
testinginterface "github.com/mitchellh/go-testing-interface" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I initially had something like this, but GoLand "helpfully" changed it when I refactored something. I'll switch it back.
When bumping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explainer, LGTM!
Thanks! |
This requires bumping https://github.com/mitchellh/go-testing-interface.
For this new version, we have to create a wrapper to convert
the stdlib
testing.TB
interface to themitchellh/go-testing-interface
T
interface, since it usesParallel()
now, which is not supported bytesting.TB
. This had to beadded to a new package,
benchhelpers
, to avoid a circular dependencyin
testhelpers
.We also have to unbump https://github.com/armon/go-metrics since
updating it breaks our usage of
https://github.com/google/go-metrics-stackdriver
I verified that the new
pkiCert
template function works with agentinjection using annotations like: