Remove duplicated certificates from chains #14348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by Steve Clark, building an intermediate mount in PKI (and
calling
/intermediate/set-signed
) results in a duplicate intermediate CAcertificate in the full chain output (
ca_chain
field of the/cert/ca_chain
API endpoint response).While ideally we'd use proper chain building (and return a sorted
chain), for the time being, return certs in the order they appear and
remove any duplicate certificates.
Signed-off-by: Alexander Scheel <[email protected]>
--
This was for the new full chain feature introduced in #13935.
Reproducer: