Add full CA Chain to /pki/cert/ca_chain response #13935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows callers to get the full chain (including issuing certificates) from a call to /cert/ca_chain. Previously, most endpoints (including during issuance) do not include the root authority, requiring an explicit call to /cert/ca to fetch. This allows full chains to be constructed without without needing multiple calls to the API. Resolves: #13489 Signed-off-by: Alexander Scheel <[email protected]>
We test three main scenarios:
1. A root-only CA's `/cert/ca_chain`'s `.data.ca_chain` field should
contain only the root,
2. An intermediate CA (with root provide) should contain both the root
and the intermediate.
3. An external (e.g., `/config/ca`-provided) CA with both root and
intermediate should contain both certs.
Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
force-pushed
the
cipherboy-add-ca-chain
branch
from
a971f57 to
fa29083
Compare
kitography
approved these changes
Feb 7, 2022
divyapola5
approved these changes
Feb 7, 2022
Signed-off-by: Alexander Scheel <[email protected]>
|
Thanks @stevendpclark, I've added a note -- let me know if that seems right? |
stevendpclark
approved these changes
Feb 7, 2022
|
Thanks all for the reviews! Going ahead and merging. :-) |
fairclothjm
pushed a commit
that referenced
this pull request
Feb 12, 2022
* Include full chain in /cert/ca_chain response This allows callers to get the full chain (including issuing certificates) from a call to /cert/ca_chain. Previously, most endpoints (including during issuance) do not include the root authority, requiring an explicit call to /cert/ca to fetch. This allows full chains to be constructed without without needing multiple calls to the API. Resolves: #13489 Signed-off-by: Alexander Scheel <[email protected]> * Add test case for full CA issuance We test three main scenarios: 1. A root-only CA's `/cert/ca_chain`'s `.data.ca_chain` field should contain only the root, 2. An intermediate CA (with root provide) should contain both the root and the intermediate. 3. An external (e.g., `/config/ca`-provided) CA with both root and intermediate should contain both certs. Signed-off-by: Alexander Scheel <[email protected]> * Add documentation for new ca_chain field Signed-off-by: Alexander Scheel <[email protected]> * Add changelog entry Signed-off-by: Alexander Scheel <[email protected]> * Add note about where to find the entire chain Signed-off-by: Alexander Scheel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #13489, calls to read
/pki/cert/ca_chainwould return a partial chain, excluding the root authority. By adding a new field,ca_chainto the response, we can include the entire chain without breaking backwards compatibility.We test three main scenarios:
/cert/ca_chain's.data.ca_chainfield should contain only the root,/config/ca-provided) CA with both root and intermediate should contain both certs.n.b.: I think the existing note around
ca_chainin the documentation is wrong, hence its removal.Additional note: this is only the full chain as known to Vault. If the entire (from a TLS client's PoV) chain wasn't provided during either
/intermediate/set-signedor/config/ca, Vault wouldn't know the entire chain and thus couldn't provided. That'd be an enhancement for the future.