-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for consul namespaces and admin partitions #13850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just a few small suggestions
…spaces and partitions
To test the enterprise features, you must set and export the CONSUL_LICENSE variable with a Consul enterprise license key. It was simpler to use the license variable directly and pass it into the test container rather than use a license file and and have to mount it on a docker volume. However, if that's a better implementation then it can be changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, left a few small comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment, but otherwise looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…#13850) * Add support for consul namespaces and admin partitions
Consul has a few new features we'd like to add support for in the Consul secrets engine. This PR is to add support for both Namespaces and Admin Partitioning.