Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for consul namespaces and admin partitions #13850

Merged
merged 9 commits into from
Feb 9, 2022

Conversation

robmonte
Copy link
Member

Consul has a few new features we'd like to add support for in the Consul secrets engine. This PR is to add support for both Namespaces and Admin Partitioning.

@vercel vercel bot temporarily deployed to Preview – vault February 1, 2022 21:54 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 1, 2022 21:54 Inactive
@robmonte robmonte marked this pull request as ready for review February 2, 2022 04:30
@robmonte robmonte requested a review from a team February 2, 2022 04:30
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a few small suggestions

builtin/logical/consul/path_roles.go Show resolved Hide resolved
builtin/logical/consul/path_token.go Outdated Show resolved Hide resolved
builtin/logical/consul/path_token.go Outdated Show resolved Hide resolved
builtin/logical/consul/path_token.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault February 2, 2022 21:49 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 2, 2022 21:49 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 2, 2022 21:58 Inactive
@vercel vercel bot temporarily deployed to Preview – vault February 2, 2022 21:58 Inactive
@austingebauer austingebauer self-requested a review February 3, 2022 18:24
@calvn calvn self-requested a review February 3, 2022 21:40
@calvn calvn added this to the 1.10 milestone Feb 3, 2022
builtin/logical/consul/path_roles.go Outdated Show resolved Hide resolved
builtin/logical/consul/path_token.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault February 7, 2022 11:46 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 7, 2022 11:46 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 7, 2022 19:52 Inactive
@vercel vercel bot temporarily deployed to Preview – vault February 7, 2022 19:52 Inactive
@robmonte robmonte requested a review from calvn February 7, 2022 19:53
@robmonte
Copy link
Member Author

robmonte commented Feb 7, 2022

To test the enterprise features, you must set and export the CONSUL_LICENSE variable with a Consul enterprise license key. It was simpler to use the license variable directly and pass it into the test container rather than use a license file and and have to mount it on a docker volume. However, if that's a better implementation then it can be changed.

Copy link
Contributor

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a few small comments!

helper/testhelpers/consul/consulhelper.go Outdated Show resolved Hide resolved
helper/testhelpers/consul/consulhelper.go Outdated Show resolved Hide resolved
builtin/logical/consul/backend_test.go Outdated Show resolved Hide resolved
builtin/logical/consul/backend_test.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault February 8, 2022 23:06 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 8, 2022 23:06 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 9, 2022 04:05 Inactive
@vercel vercel bot temporarily deployed to Preview – vault February 9, 2022 04:05 Inactive
Copy link
Contributor

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, but otherwise looks great!

helper/testhelpers/consul/consulhelper.go Show resolved Hide resolved
Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vercel vercel bot temporarily deployed to Preview – vault February 9, 2022 20:47 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 9, 2022 20:47 Inactive
@robmonte robmonte merged commit ba16684 into main Feb 9, 2022
@robmonte robmonte deleted the consul-scrt-eng-upd branch February 9, 2022 21:45
@calvn calvn mentioned this pull request Feb 12, 2022
fairclothjm pushed a commit that referenced this pull request Feb 12, 2022
…#13850)

* Add support for consul namespaces and admin partitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants