-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consul acl role support #14014
Consul acl role support #14014
Conversation
Allows an operator to create a vault-consul role that can create consul tokens that are bound to a consul acl role.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise LGTM along with Calvin's suggestions. Great level of detail with the description and documentation 👍
This reverts commit cc43fbf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This is a refresh of the PR submitted by @BrandonIngalls here: #11025 which adds support for Consul ACL roles. This simplifies management of Vault tokens that use multiple Consul policies. Previously, you needed to replicate the work of assigning multiple Consul policies to a role in both Vault and Consul.
For example, let's say you work on assigning 20 different ACL policies into a single Consul role named "admin-access". With current Vault, you'd need to assign all 20 polices again to a Vault role like this:
With Consul role support, it changes to this:
Additionally, if you want to assign multiple Consul roles to a Vault role, you can:
The original author's commits are retained to preserve credit for the work generously provided, save for merge conflicts, and the CLA was previously signed here: #11025 (comment)
Closes #10752, #11025