Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/Fix node-forge EC error #13238

Merged
merged 12 commits into from
Nov 23, 2021
Merged

UI/Fix node-forge EC error #13238

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
213d7d3
add catch for node-forge error handling
hellobontempo Nov 19, 2021
1a6395f
update comment
hellobontempo Nov 22, 2021
ec9ce56
adds changelog
hellobontempo Nov 22, 2021
1803842
alphabetize attrs and add canParse attr
hellobontempo Nov 22, 2021
b3e3f76
show alert banner if unable to parse metadata
hellobontempo Nov 22, 2021
0ef047a
add alert banner to CA certs
hellobontempo Nov 22, 2021
05c40c5
change conditional in case canParse is undefined
hellobontempo Nov 22, 2021
145367f
fixes indentation
hellobontempo Nov 23, 2021
80b1fe3
fixes if statement syntax
hellobontempo Nov 23, 2021
2a4c49b
add test to check info banner renders
hellobontempo Nov 23, 2021
34e422c
remove unused var?
hellobontempo Nov 23, 2021
b89e7f9
update verbiage for CA certs
hellobontempo Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/13238.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
ui: Fixes node-forge error when parsing EC (elliptical curve) certs
```
9 changes: 8 additions & 1 deletion ui/app/helpers/parse-pki-cert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,14 @@ export function parsePkiCert([model]) {
if (!model.certificate) {
return;
}
const cert = pki.certificateFromPem(model.certificate);
let cert;
// node-forge cannot parse EC (elliptical curve) certs
// return original response if unable to convert a Forge cert from PEM
try {
cert = pki.certificateFromPem(model.certificate);
} catch (error) {
return model;
}
const commonName = cert.subject.getField('CN') ? cert.subject.getField('CN').value : null;
const issueDate = cert.validity.notBefore;
const expiryDate = cert.validity.notAfter;
Expand Down