-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/Fix node-forge EC error #13238
UI/Fix node-forge EC error #13238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thanks for the quick fix!
Just to mention, we tested this via setting up two secrets engines:
One CA was with RSA and the other was with EC. Since the root CA certificate for the mount is visible from the secrets page, we were able to confirm the original issue and that this fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Don't forget the bug and ui label and the milestone. (unsure if this is being backported to 1.9, guessing it is?)
\\\\ q
* add catch for node-forge error handling * update comment * adds changelog * alphabetize attrs and add canParse attr * show alert banner if unable to parse metadata * add test to check info banner renders
Fix for #13219
Adds a catch for when
node-forge
returns an error converting or parsing a certificate, and returns unparsed certificate (so metadata will not display).Addresses error returned when trying to read EC certs.
Error: Cannot read public key. OID is not RSA.
When unable to parse certificate metadata, UI reverts to original behavior and just displays serial number and certificate: