Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets header version badge #13015

Merged
merged 7 commits into from
Nov 8, 2021
Merged

Secrets header version badge #13015

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7f88573
updates secret list header to display badge for all versions
zofskeez Nov 2, 2021
aa27c03
adds changelog entry
zofskeez Nov 2, 2021
a1cb04b
updates secret list header to only show badge for kv and generic engi…
zofskeez Nov 3, 2021
89c647d
adds secret-engine mirage factory
zofskeez Nov 3, 2021
72fc09d
adds test helper for pushing serialized mirage data into store and re…
zofskeez Nov 3, 2021
31b2f0a
adds secret engine type version badge display test
zofskeez Nov 3, 2021
dc00130
updates mirage application serializer to return singular type key
zofskeez Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/13015.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
ui: Display badge for all versions in secrets engine header
```
8 changes: 3 additions & 5 deletions ui/app/templates/components/secret-list-header.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@
<h1 class="title is-3">
<Icon @glyph={{or @model.engineType "secrets"}} @size="xl" class="has-text-grey-light" />
{{@model.id}}
{{#if (eq @model.options.version 2)}}
hashishaw marked this conversation as resolved.
Show resolved Hide resolved
<span class="tag">
Version 2
</span>
{{/if}}
<span class="tag">
Version {{or @model.options.version "1"}}
</span>
</h1>
</p.levelLeft>
</PageHeader>
Expand Down