Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secrets header version badge #13015

Merged
merged 7 commits into from
Nov 8, 2021
Merged

Secrets header version badge #13015

merged 7 commits into from
Nov 8, 2021

Conversation

zofskeez
Copy link
Contributor

@zofskeez zofskeez commented Nov 2, 2021

Small change to always show the version badge in the secrets engine header.

image

@zofskeez zofskeez added the ui label Nov 2, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook November 2, 2021 20:06 Inactive
@vercel vercel bot temporarily deployed to Preview – vault November 2, 2021 20:06 Inactive
hashishaw
hashishaw suggested changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a little test too

ui/app/templates/components/secret-list-header.hbs Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault November 3, 2021 00:32 Inactive
@vercel vercel bot temporarily deployed to Preview – vault November 3, 2021 02:52 Inactive
@zofskeez
Copy link
Contributor Author

zofskeez commented Nov 3, 2021

@hashishaw I made the change to only show the badge for kv and generic engine types and added a test. I also added a mirage factory for the secret-engine model as well as a test helper to return ember data models when given models generated by mirage. This could be convenient in integration tests when the component expects a model as an argument rather than stubbing out a pojo.

@zofskeez zofskeez requested a review from hashishaw November 3, 2021 21:43
hashishaw
hashishaw approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@hashishaw hashishaw added this to the 1.10 milestone Nov 8, 2021
@zofskeez zofskeez merged commit f1dc962 into main Nov 8, 2021
@zofskeez zofskeez deleted the ui/secrets-kv1-badge branch November 8, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashishaw hashishaw hashishaw approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@zofskeez @hashishaw