UI/control group db cred #12024
Merged
UI/control group db cred #12024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
reviewed
Jul 9, 2021
| } | ||
|
|
||
| @task(function*() { |
There was a problem hiding this comment.
much cleaner, thank you for moving this logic out of the component.
Monkeychip
reviewed
Jul 9, 2021
| @@ -38,7 +38,7 @@ | |||
| {{on 'click' (fn this.generateCreds @model.id)}} | |||
| data-test-database-role-generate-creds | |||
| > | |||
| Generate credentials | |||
| {{if (eq @model.type "static") "Get credentials" "Generate credentials"}} | |||
There was a problem hiding this comment.
thank you for tackling this while you're in here
Monkeychip
reviewed
Jul 9, 2021
| @@ -18,15 +18,15 @@ | |||
| </p.levelLeft> | |||
Monkeychip
reviewed
Jul 9, 2021
Monkeychip
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where control groups were not working properly on database credential paths. It now works as expected (approver on left, requester on right):
The language for "Generate credentials" has also been updated for static type roles only:
