Vault UI "Generate credentials" functionality should instead be called "Get credentials" for static database roles

[berciq]

Describe the bug
The database plugin allows for creating static and dynamic roles. For both types of roles the Vault UI has a "Generate credentials" option. This makes sense for a dynamic database role, because new credentials are, in fact, generated each time this option is used. But the name of this option is misleading for a static role, since Vault UI will display the existing credentials upon selecting this option. What is more, Vault UI displays a warning message when selecting "Generate credentials" that says: "You will not be able to access these credentials later, so please copy them now." But this is only true for a dynamic role and not for a static role. The warning message should not be displayed for the static role, since the credentials can, in fact, be accessed later.

To Reproduce
Steps to reproduce the behavior:

1. Configure the database secrets engine (e.g. as described here)
2. Create a static database role as described here
3. Open the Vault UI
4. Access the list of database roles
5. Your configured static database role will have an option to "Generate credentials" - which is misleading

Expected behavior
For static database roles, the option to "Generate credentials" should instead be called something like "Get credentials".
In addition, for static roles, the page where the credentials are displayed should not show the warning message that says: "You will not be able to access these credentials later, so please copy them now."

Environment:

• Vault Server Version (retrieve with vault status): Vault 1.8.0-dev

Screenshots:

[heatherezell]

Hello! I'm raising this for discussion with our UI team. With the Canada Day and July 4th holidays, it may be next week before I can get in touch with them. I'll be sure to be in touch then. Thank you for this feedback!

[heatherezell]

Just wanted to follow up - I've raised this issue with our UI team, and we'll be taking an item in an upcoming sprint to address it. I'm not exactly sure when that will be, but it will be worked on. Thanks for your patience!

[berciq]

Just wanted to follow up - I've raised this issue with our UI team, and we'll be taking an item in an upcoming sprint to address it. I'm not exactly sure when that will be, but it will be worked on. Thanks for your patience!

Thank you, Heather! I'd be happy to contribute to improving the UI in this area as well :)

[heatherezell]

Hi @berciq! It looks like this has been fixed with PR #12024. Let me know if that addresses your concerns. :)

[berciq]

@hsimon-hashicorp yes, this mostly fixes it. The terminology was changed to "Get credentials". However, I'm still seeing the warning screen after pulling in the most recent changes:

[berciq]

The following PR fixes this: #12148

[heatherezell]

@berciq Very nice, thank you for catching that and for submitting the PR. :)