1.15.x: revert bound audiences behavior change #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
commented
Jun 13, 2024
| @@ -269,69 +445,6 @@ func testLogin_JWT(t *testing.T, jwks bool) { | |||
| } | |||
| } | |||
|
|
|||
| // Test bound audiences unset, claims "aud" set | |||
There was a problem hiding this comment.
This test case is captured in the new test
thyton
reviewed
Jun 13, 2024
Comment on lines
+100
to
+102
| fmt.Println() | ||
| fmt.Println(authURL) | ||
| fmt.Println() |
There was a problem hiding this comment.
Suggested change
| fmt.Println() | |
| fmt.Println(authURL) | |
| fmt.Println() | |
| fmt.Println() | |
| fmt.Println(authURL) | |
| fmt.Println() |
thyton
approved these changes
Jun 13, 2024
Comment on lines
+100
to
+102
| fmt.Println() | ||
| fmt.Println(authURL) | ||
| fmt.Println() |
There was a problem hiding this comment.
Suggested change
| fmt.Println() | |
| fmt.Println(authURL) | |
| fmt.Println() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes to revert the change made in #295 to address CVE-2024-5798.
We add a new test
TestLoginBoundAudiencesto test the behavior expectations.Background
#295 fixed a bug where the login JWT's
audclaim is ignored if it is a single string. The net effect is that the role'sbound_audiencesparameter must match at least one of the JWT'saudclaims if the token has anaudclaim.Since the behavior change is a breaking change, we are reverting the change in the Vault versions after 1.15.10 and 1.16.4. However, the behavior change will go into effect in Vault 1.17 and later.
Relates