Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalidate JWT with single non-empty string aud on empty bound audiences #295

Merged
merged 3 commits into from
Apr 12, 2024
Merged

invalidate JWT with single non-empty string aud on empty bound audiences #295

merged 3 commits into from
Apr 12, 2024

Conversation

thyton
Copy link
Contributor

@thyton thyton commented Apr 12, 2024

Overview

Our JWT invalidation on empty bound audiences currently includes only the non-empty string array "aud" case. However, https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.3 states

In the special case when the JWT has one audience, the "aud" value MAY be a single case-sensitive string containing a StringOrURI value.

Design of Change

@thyton thyton changed the title invalidate JWT with single non-empty string aud when bound audiences are empty invalidate JWT with single non-empty string aud on empty bound audiences Apr 12, 2024
@thyton thyton requested a review from a team April 12, 2024 00:01
@thyton thyton marked this pull request as draft April 12, 2024 00:03
@thyton thyton marked this pull request as ready for review April 12, 2024 00:08
@thyton thyton merged commit b8833ce into main Apr 12, 2024
4 checks passed
@thyton thyton deleted the VAULT-25183-increase-audience-validation branch April 12, 2024 16:57
@mcollao-hc mcollao-hc mentioned this pull request Apr 16, 2024
Closed
@thyton thyton linked an issue Apr 23, 2024 that may be closed by this pull request
Audience claim validation required if token contains a list of audiences only #274
Closed
thyton added a commit that referenced this pull request May 10, 2024
@thyton
backport into release/0.17.x invalidate JWT with single non-empty str…
fcee75c 
…ing aud on empty bound audiences (#295)
@thyton thyton mentioned this pull request May 10, 2024
Closed
thyton added a commit that referenced this pull request May 11, 2024
@thyton
backport into release/v0.17.x b8833ce and prepare release v0.17.3 (#295)
4552768
@thyton thyton mentioned this pull request May 11, 2024
Merged
thyton added a commit that referenced this pull request May 14, 2024
@thyton
backport into release/v0.17.x b8833ce and prepare release v0.17.3 (#295…
90f0fed 
…) (#300)
thyton added a commit that referenced this pull request May 15, 2024
@thyton
backport into release/v0.16.x b8833ce and prepare release v0.16.1 (#295)
282745f
@thyton thyton mentioned this pull request May 15, 2024
Merged
thyton added a commit that referenced this pull request May 16, 2024
@thyton
backport into release/v0.16.x b8833ce and prepare release v0.16.1 (#295…
7856db6 
…) (#303)
This was referenced Jun 13, 2024
Merged
Merged
fairclothjm added a commit that referenced this pull request Jun 13, 2024
@fairclothjm
Revert "invalidate JWT with single non-empty string aud on empty boun…
7451b17 
…d audiences (#295)"

This reverts commit b8833ce.
@fairclothjm fairclothjm mentioned this pull request Jun 13, 2024
Merged
fairclothjm added a commit that referenced this pull request Jun 13, 2024
@fairclothjm
1.16.x: revert bound audiences behavior change (#310)
3962fb9 
* Revert "invalidate JWT with single non-empty string aud on empty bound audiences (#295)"

This reverts commit b8833ce.

* use new go-jose repo and bump to v3

* add test and remove redundant test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairclothjm fairclothjm fairclothjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audience claim validation required if token contains a list of audiences only
2 participants
@thyton @fairclothjm