Group aliases, project_id --> optional bound_projects, no caching GCP API clients #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
emilymye
commented
Nov 7, 2018
•
emilymye
commented
- Add ability to enable group aliases (opt-in because additional permissions are required)
- Deprecate required field project_id, add optional field bound_projects; if included, authenticating entity must belong to bound_projects
- No caching GCP API clients: Removes token staleness issue and in general I don't think it wasn't necessary
- Added local_dev script for ease of testing.
sethvargo
suggested changes
Nov 7, 2018
sethvargo
approved these changes
Nov 10, 2018
kalafut
pushed a commit
to hashicorp/vault
that referenced
this pull request
Dec 10, 2018
Documented changes from hashicorp/vault-plugin-auth-gcp#55 * Deprecating `project_id` for `bound_projects` and making it optional * Deprecating `google_certs_endpoint` (unused) * Adding group aliases Also, some general reformatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.