Fix gcp_auth_backend_role #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
I believe the tests are failing because the integration test is using an older version of Vault which doesn't contain this change. Is it possible to setup a matrix of integration tests against multiple Vault versions? |
Ginja
force-pushed
the
fix-gcp-auth-role-resource
branch
from
f1545a2
to
864ccc2
Compare
|
This is still needed as it fixes a idempotency issue we were seeing with utilizing The Travis-CI checks will be failing because the |
|
Looks like this is now resolved by #292. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #228, but I was also seeing the same behaviour with the
project_idattribute. Upon looking into this it looks like this attribute has been renamed tobound_projects(see this PR too).This PR removes
project_id, addsbound_projects, and I've gone ahead and cherry-picked @Phylu's commit from his open PR 🙏I also noticed that most of the optional attributes were set toComputed: true, and I believe this is to be wrong. I'll revert this change if asked, but what I was seeing when it was set to true was the removal of an optional attribute failing to trigger an update to thegcp_auth_backend_roleresource.These changes were tested locally with Vault version 1.0.1 & Terraform 0.11.0.