Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for system & user-assigned identity auth & misc #50

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Allow for system & user-assigned identity auth & misc #50

merged 1 commit into from
Feb 15, 2022

Conversation

elsesiy
Copy link
Contributor

@elsesiy elsesiy commented Feb 8, 2022

Overview

  • Update to go1.17.6
  • Rev dependencies
  • Use 2021-11-01 compute client sdk
  • Remove unused params & address other codestyle issues

Related Issues/Pull Requests

Fix #35

Contributor Checklist

[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR Link
Example
[ ] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[x] Backwards compatible

- Update to go1.17.6
- Rev dependencies
- Use 2021-11-01 compute client sdk
- Remove unused params & address other codestyle issues

Fix #35
@elsesiy elsesiy marked this pull request as ready for review February 8, 2022 07:51
@elsesiy
Copy link
Contributor Author

elsesiy commented Feb 8, 2022

@calvn Tagging you since you reviewed my past PRs, thanks!

@jasonodonnell jasonodonnell self-requested a review February 14, 2022 16:33
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested fine. Thanks for the contribution!

@jasonodonnell
Copy link
Contributor

We're double checking some dependency updates with the Vault project, then will merge if things look good!

@jasonodonnell jasonodonnell merged commit f607d9a into hashicorp:master Feb 15, 2022
jasonodonnell pushed a commit that referenced this pull request Feb 17, 2022
- Update to go1.17.6
- Rev dependencies
- Use 2021-11-01 compute client sdk
- Remove unused params & address other codestyle issues

Fix #35
jasonodonnell added a commit that referenced this pull request Feb 17, 2022
* Allow for system & user-assigned identity auth & misc (#50)

- Update to go1.17.6
- Rev dependencies
- Use 2021-11-01 compute client sdk
- Remove unused params & address other codestyle issues

Fix #35

* Use object ID for the logical name (#34)

Co-authored-by: Jonas-Taha El Sesiy <[email protected]>
Co-authored-by: cccs-ob <[email protected]>
@elsesiy elsesiy deleted the feat/issue-35 branch February 22, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

system-assigned identity and user-assigned identity are mutually exclusive
2 participants