Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-assigned identity and user-assigned identity are mutually exclusive #35

Closed
sfc-gh-emonsef opened this issue Aug 13, 2020 · 0 comments · Fixed by #50
Closed

system-assigned identity and user-assigned identity are mutually exclusive #35

sfc-gh-emonsef opened this issue Aug 13, 2020 · 0 comments · Fixed by #50

Comments

@sfc-gh-emonsef
Copy link

If a vm has both system-identity and user-identity, the existing code only considers the system-identity and will not consider user-identity.

vault-plugin-auth-azure/path_login.go

Line 270 in 82c8372

break

Is it possible to remove this break so we could use user-identity on a VM that has both system identity and user identity?

Thanks
@elsesiy elsesiy mentioned this issue Feb 8, 2022
Merged
jasonodonnell pushed a commit that referenced this issue Feb 15, 2022
@elsesiy
Allow for system & user-assigned identity auth & misc (#50)
f607d9a 
- Update to go1.17.6
- Rev dependencies
- Use 2021-11-01 compute client sdk
- Remove unused params & address other codestyle issues

Fix #35
jasonodonnell pushed a commit that referenced this issue Feb 17, 2022
@elsesiy @jasonodonnell
Allow for system & user-assigned identity auth & misc (#50)
6f6b279 
- Update to go1.17.6
- Rev dependencies
- Use 2021-11-01 compute client sdk
- Remove unused params & address other codestyle issues

Fix #35
@jasonodonnell jasonodonnell mentioned this issue Feb 17, 2022
Merged
jasonodonnell added a commit that referenced this issue Feb 17, 2022
@jasonodonnell @elsesiy @cccs-ob
Backport 1.9: add PR #34 and #35 (#51)
64d90e5 
* Allow for system & user-assigned identity auth & misc (#50)

- Update to go1.17.6
- Rev dependencies
- Use 2021-11-01 compute client sdk
- Remove unused params & address other codestyle issues

Fix #35

* Use object ID for the logical name (#34)

Co-authored-by: Jonas-Taha El Sesiy <[email protected]>
Co-authored-by: cccs-ob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow for system & user-assigned identity auth & misc
1 participant
@sfc-gh-emonsef