-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support for nested Hyper-V #7738
Conversation
Great! A smaller PR is more likely to get merged. Do you want to add the new key in the docs https://github.com/mitchellh/vagrant/blob/6c01aaf6aba425620751d9a7b21572a889380f72/website/source/docs/hyperv/configuration.html.md as well? |
@StefanScherer thanks! I didn't notice those docs were in the same repo. Updated. |
👍 I tested this with:
And then confirmed via:
|
Ping @mitchellh - is there anything else I need to do to have this (and other) PRs considered? I have a few more things I'd like to contribute as well related to Hyper-V |
@PatrickLang once I finish getting my hyperv env setup I'll be running through these |
@chrisroberts feel free to ping me if you have any questions on it. I'm part of that team although I focus mainly on Windows containers these days. |
See: hashicorpGH-7597. Due to the childprocess gem setting STDIN to a pipe, Docker will fail as it requires STDIN to be a TTY if run with --interactive.
Fix non upstart linux nfs mounts
…ractive-flag Remove --interactive flag from Docker command
Remove executable permissions.
Use comma to set off nonrestrictive clause.
Fixes: hashicorp#7728 Signed-off-by: guessi <[email protected]>
…der vagrant boxes that added an XML file manually
Fix typo (netmast => netmask) for Photon guest hashicorp#7808
redirect any output to stderr by /sbin/init to /dev/null when checking for upstart capability
…teractive Prevent interaction when removing plugin gems
Remove direct bundler usage within Env util
Package Hyper-V boxes
…tation Hyper-V package documentation
Show comma separated include for package
Hmm, how did the unrelated comments end up here? |
Hi @PatrickLang! I have cherrypicked your commits out into an isolated branch and created a new PR for this enhancement here: #8325. Thank you very much for this contribution and please know that even though this PR is getting closed, your code is still getting merged. Cheers! |
Thanks! I'll track the other PR |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Windows 10 1511 (build 10586) and 1607 (build 14393), along with Windows Server 2016 Technical Preview 5 all support nesting the Hyper-V role inside of a Hyper-V virtual machine. This can be enabled with a simple call to the PowerShell cmdlet
Set-VMProcessor
. This PR adds that ability