Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for nested Hyper-V #7738

Closed
wants to merge 304 commits into from

Conversation

PatrickLang
Copy link
Contributor

Windows 10 1511 (build 10586) and 1607 (build 14393), along with Windows Server 2016 Technical Preview 5 all support nesting the Hyper-V role inside of a Hyper-V virtual machine. This can be enabled with a simple call to the PowerShell cmdlet Set-VMProcessor . This PR adds that ability

@StefanScherer
Copy link
Contributor

Great! A smaller PR is more likely to get merged. Do you want to add the new key in the docs https://github.com/mitchellh/vagrant/blob/6c01aaf6aba425620751d9a7b21572a889380f72/website/source/docs/hyperv/configuration.html.md as well?

@PatrickLang
Copy link
Contributor Author

@StefanScherer thanks! I didn't notice those docs were in the same repo. Updated.

@mwrock
Copy link
Contributor

mwrock commented Aug 21, 2016

👍 I tested this with:

  config.vm.provider "hyperv" do |hv|
    hv.enable_virtualization_extensions = true
  end

And then confirmed via:

C:\dev\vagrantfile [master +2 ~0 -0 !]> Get-VMProcessor -VMName packer-hyperv-iso | fl


ResourcePoolName                             : Primordial
Count                                        : 1
CompatibilityForMigrationEnabled             : False
CompatibilityForOlderOperatingSystemsEnabled : False
HwThreadCountPerCore                         : 1
ExposeVirtualizationExtensions               : True

@PatrickLang
Copy link
Contributor Author

Ping @mitchellh - is there anything else I need to do to have this (and other) PRs considered? I have a few more things I'd like to contribute as well related to Hyper-V

@chrisroberts
Copy link
Member

@PatrickLang once I finish getting my hyperv env setup I'll be running through these

@PatrickLang
Copy link
Contributor Author

@chrisroberts feel free to ping me if you have any questions on it. I'm part of that team although I focus mainly on Windows containers these days.

@chrisroberts chrisroberts added this to the 1.9 milestone Sep 30, 2016
hunterboerner and others added 17 commits October 5, 2016 14:38
See: hashicorpGH-7597. Due to the childprocess gem setting STDIN to a pipe,
Docker will fail as it requires STDIN to be a TTY if run with
--interactive.
…ractive-flag

Remove --interactive flag from Docker command
Use comma to set off nonrestrictive clause.
…der vagrant boxes that added an XML file manually
chrisroberts and others added 23 commits December 5, 2016 15:20
redirect any output to stderr by /sbin/init to /dev/null when checking for upstart capability
…teractive

Prevent interaction when removing plugin gems
Remove direct bundler usage within Env util
Show comma separated include for package
@PatrickLang
Copy link
Contributor Author

Hmm, how did the unrelated comments end up here?

@chrisroberts chrisroberts mentioned this pull request Mar 2, 2017
@chrisroberts
Copy link
Member

Hi @PatrickLang! I have cherrypicked your commits out into an isolated branch and created a new PR for this enhancement here: #8325. Thank you very much for this contribution and please know that even though this PR is getting closed, your code is still getting merged. Cheers!

@PatrickLang
Copy link
Contributor Author

Thanks! I'll track the other PR

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.