Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo (netmast => netmask) for Photon guest #7808 #7873

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

markpeek
Copy link
Contributor

@markpeek markpeek commented Oct 6, 2016

No description provided.

Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for this PR but the tests are currently failing (due to the same typo in the test code). Please update to allow passing tests. Thanks so much!

@chrisroberts
Copy link
Member

Fixes: #7808

@markpeek markpeek force-pushed the markpeek-photon-netmask branch from bc230d0 to 4bf32e3 Compare October 7, 2016 19:33
@markpeek
Copy link
Contributor Author

markpeek commented Oct 7, 2016

@chrisroberts thanks for the heads up on the tests failing. Fix was pushed and now passes.

@chrisroberts
Copy link
Member

@markpeek Thanks!

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants