-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Allow aws_instances to be resized rather than forcing a new instance #11998
Conversation
c22be9c
to
ea634bc
Compare
ea634bc
to
3e7a0f3
Compare
3e7a0f3
to
91c3200
Compare
new instance Fixes: #9157 ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSInstance_changeInstanceType' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/02/16 15:13:21 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSInstance_changeInstanceType -timeout 120m === RUN TestAccAWSInstance_changeInstanceType --- PASS: TestAccAWSInstance_changeInstanceType (303.85s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 303.876s ```
91c3200
to
494398d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🇱🇹
…#11998) new instance Fixes: #9157 ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSInstance_changeInstanceType' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/02/16 15:13:21 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSInstance_changeInstanceType -timeout 120m === RUN TestAccAWSInstance_changeInstanceType --- PASS: TestAccAWSInstance_changeInstanceType (303.85s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 303.876s ```
What happens when you are resizing an ebs optimised instance to a non-ebs optimised instance, like an m4.large to an t2.large? |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes: #9157