Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Prevent instance destroy on machine_type change #380

Closed
TraGicCode opened this issue Sep 1, 2017 · 5 comments
Closed

[Feature] Prevent instance destroy on machine_type change #380

TraGicCode opened this issue Sep 1, 2017 · 5 comments
Assignees

Comments

@TraGicCode
Copy link

TraGicCode commented Sep 1, 2017

Terraform Version

v0.10.2

Plugin Version

google (0.1.3)

Affected Resource(s)

Please list the resources as a list, for example:

  • google_compute_instance

When changing the machine_type of an already created instance terraform thinks it should recreate the instance when a modified should be done. Also google requires the machine to be stopped before you can change the type. Not sure how this affects things.

@rosbo
Copy link
Contributor

rosbo commented Sep 7, 2017

You are listing Oracle Public Cloud resources as the affected resources but mentions google in your comment. Did you mean google_compute_instance in the affected resources section?

@TraGicCode
Copy link
Author

Yes I did sorry I didn't replace that from the pr template

@paddycarver
Copy link
Contributor

Looks like this is similar to hashicorp/terraform#11998. I don't see why we couldn't apply the similar logic/workflow here. I'll open a quick PR.

@rosbo
Copy link
Contributor

rosbo commented Nov 24, 2017

Duplicate. Closing in favor of #728 which contains more details and implementation ideas.

@rosbo rosbo closed this as completed Nov 24, 2017
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this issue May 21, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants