Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional changes like those in #1305/#1479 #1583

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Additional changes like those in #1305/#1479 #1583

merged 1 commit into from
Aug 19, 2022

Conversation

bwagner3slb
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #1305 and #1479

Release note for CHANGELOG:

Fixing vault/resource_azure_auth_backend_config.go to make it work better with namespaces.

Output from acceptance testing:

The following fails even on a clean clone of main this test and all of the others in the MAKEFILE fail.
$ make testacc TESTARGS='-run=TestAccXXX'

...

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 16, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

vinay-gopalan
vinay-gopalan approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your contribution!

@vinay-gopalan vinay-gopalan merged commit 4846a3a into hashicorp:main Aug 19, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@bwagner3slb
Additional changes like those in hashicorp#1305/hashicorp#1479 (hashi…
fae3154 
…corp#1583)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwagner3slb @hashicorp-cla @vinay-gopalan