-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace by resource #1305
Namespace by resource #1305
Conversation
- prototype of a function wrapper for calling resource functions with the namespaced api.Client - other misc.
- remove CallWithClient()
This is huge and would simplify my tf code base for enterprise vault a lot. Hope we can get this soon merged :) |
36bdf36
to
92d2bff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Had a couple questions :)
- add tests for provider.GetClient() - use some env var constants from the `vault/api` package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and tests are looking great!
This change adds support for configuring namespaces at the resource or data source level. All namespace directives are applied relative to the provider's configured namespace. This new approach allows for namespace'd resources to be created without having to pass a namespace specific provider, although that method is still fully supported.
This change adds support for configuring namespaces at the resource or data source level. All namespace directives are applied relative to the provider's configured namespace. This new approach allows for namespace'd resources to be created without having to pass a namespace specific provider, although that method is still fully supported.
This is an initial POC that adds the
namespace
field to all Vaultresources
anddatasources
. Allnamespace
directives are applied relative to the provider's configurednamespace
. This new approach allows for namespaced resources to be created without having to specify a namespace specific provider.More to come.
Example using
for_each
Community Note
Relates #546
Release note for CHANGELOG:
Output from acceptance testing: