Implement State Upgrader to Set Defaults for Attributes Assigned Null During Import #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te following import with earlier versions of the provider. For instance, using v3.3.1 to import a random password resource will result in the state file containing null values for length, lower, number, special, upper, min_lower, min_numeric, min_special, min_upper attributes.
…ld be present in state following import with earlier versions of the provider. For instance, using v3.3.1 to import a random password resource will result in the state file containing null values for length, lower, number, special, upper, min_lower, min_numeric, min_special, min_upper attributes.
…de_special and keepers in state to null.
…d with state upgrader changes handling fix of bcrypt
…tting defaults for lower, number, numeric, special, upper, min_lower, min_numeric, min_special, min_upper and setting length when these attributes have been set to null
|
I've marked this as ready for review as the code changes should be complete. Checks will fail until |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #302
In the discussion contained in Upgrade v2.2.1 -> v3.4.0 forces replacement there were several comments indicating that a forced replacement was happening under some circumstances:
The attributes in question usually have a default value of
0assigned (i.e.,min_lower,min_upper,min_numericandmin_special) ortrueassigned (i.e.,lower,upper,number,numericandspecial) when no value for them is specified in the configuration.However, under some circumstances, the attributes described can end up with a value of
nullassigned to them in the state which results in a forced update when terraform apply is run.One of the circumstances that can give rise to the storage of null values for these attributes is using terraform import with a version of the provider that is
v3.3.1or earlier. Under these circumstances, all of the attributes mentioned, along withlengthare assigned a value ofnullin state.This PR aims to address this issue by implementing a state upgrader which interrogates each of the aforementioned attributes and assigns it a default value if the value currently held for the attribute in state is
null.