Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null values in state forcing replace #311

Closed
wants to merge 2 commits into from

Conversation

bendbennett
Copy link
Contributor

There are several comments on Upgrade v2.2.1 -> v3.4.0 forces replacement which indicate that a forced recreate occurs when there are null values in the state for certain attributes:

The attributes in question appear to be:

"lower": null
"min_lower": null
"min_numeric": null
"min_special": null
"min_upper": null
"number": null
"numeric": null
"special": null
"upper": null

This PR attempts to address this issue by using a state upgrader to set each of these attributes to be non-null and to have the appropriate default value (e.g., 0 for lower, true for min_lower).

@bendbennett
Copy link
Contributor Author

Closed as superseded by #313

@bendbennett bendbennett closed this Sep 8, 2022
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant