Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set cascading delete policy to default delete option #643

Merged
merged 1 commit into from
Oct 16, 2019
Merged

set cascading delete policy to default delete option #643

merged 1 commit into from
Oct 16, 2019

Conversation

houqp
Copy link
Contributor

@houqp houqp commented Oct 10, 2019

follow up for #635.

@ghost ghost added the size/XS label Oct 10, 2019
@houqp
Copy link
Contributor Author

houqp commented Oct 15, 2019 •
edited
Loading

@alexsomesan gentle ping for a review ;)

alexsomesan
alexsomesan approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI passes

@alexsomesan alexsomesan merged commit 341f072 into hashicorp:master Oct 16, 2019
@houqp
Copy link
Contributor Author

houqp commented Oct 17, 2019

Thanks for the review @alexsomesan , do you know when will you be releasing a new version of the provider? I would like to get these fixes into our existing deployment pipeline.

@alexsomesan
Copy link
Member

alexsomesan commented Oct 17, 2019 via email

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexsomesan alexsomesan alexsomesan approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@houqp @alexsomesan