set option to cascade delete job resources #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is also the default behavior from kubectl.
|
Thank you, this is really useful! |
|
I'm testing it and will merge when green. |
alexsomesan
approved these changes
Oct 9, 2019
|
@alexsomesan I noticed other resource types like deployment also have this issue, do mind if I work on a PR to address all of them? |
|
That would be really nice! By all means, please do. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also the default behavior from kubectl.
Currently, when a job is deleted from Terraform, all pods are left behind as orphan resources.
Relates to #534.