Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated HCP Packer datasources and attributes #791

Merged
merged 6 commits into from
Mar 20, 2024
Merged

Remove deprecated HCP Packer datasources and attributes #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
99d9c4a
remove deprecated data sources and attributes
sylviamoss Mar 18, 2024
c325f9f
remove unused test meethod
sylviamoss Mar 19, 2024
44b8bab
remove deprecated docs and add changelog
sylviamoss Mar 19, 2024
667d8e5
remove packer v1 client and replace old nomenclature usage
sylviamoss Mar 19, 2024
c1db288
Merge branch 'main' into hpr-1518_remove_deprecated_datasources_attr
sylviamoss Mar 20, 2024
ff58ee4
Merge branch 'main' into hpr-1518_remove_deprecated_datasources_attr
sylviamoss Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changelog/791.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
```release-note:breaking-change
Removed `hcp_packer_iteration` data source, previously deprecated and replaced by `hcp_packer_version` in [v0.82.0](https://github.com/hashicorp/terraform-provider-hcp/releases/tag/v0.82.0).
```

```release-note:breaking-change
Removed `hcp_packer_image` data source, previously deprecated and replaced by `hcp_packer_artifact` in [v0.82.0](https://github.com/hashicorp/terraform-provider-hcp/releases/tag/v0.82.0).
```

```release-note:breaking-change
Removed `iteration_fingerprint` attribute from `hcp_packer_channel_assignment` resource, previously deprecated and replaced by `version_fingerprint` in [v0.82.0](https://github.com/hashicorp/terraform-provider-hcp/releases/tag/v0.82.0).
```
49 changes: 0 additions & 49 deletions docs/data-sources/packer_image.md
View file
Open in desktop

This file was deleted.

45 changes: 0 additions & 45 deletions docs/data-sources/packer_iteration.md
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion docs/resources/packer_channel_assignment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ resource "hcp_packer_channel_assignment" "staging" {

### Optional

- `iteration_fingerprint` (String, Deprecated) The fingerprint of the version assigned to the channel.
- `project_id` (String) The ID of the HCP project where the channel is located.
If not specified, the project specified in the HCP Provider config block will be used, if configured.
If a project is not configured in the HCP Provider config block, the oldest project in the organization will be used.
Expand Down
74 changes: 0 additions & 74 deletions internal/clients/packerv1/packer.go
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion internal/provider/packer/testutils/configbuilder/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ type HasBlockName interface {
//
// Example:
// `hcp_packer_channel.prod` (a resource) or
// `data.hcp_packer_iteration.latest` (a data source)
// `data.hcp_packer_version.latest` (a data source)
BlockName() string
}

Expand Down
3 changes: 3 additions & 0 deletions internal/providersdkv2/data_source_packer_bucket_names.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package providersdkv2
import (
"context"
"log"
"time"

"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
Expand All @@ -14,6 +15,8 @@ import (
"github.com/hashicorp/terraform-provider-hcp/internal/clients/packerv2"
)

var defaultPackerTimeout = time.Minute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this was moved here because it was previously defined in one of the removed datasources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!


func dataSourcePackerBucketNames() *schema.Resource {
return &schema.Resource{
Description: "The Packer Bucket Names data source gets the names of all of the buckets in a single HCP Packer registry.",
Expand Down
Loading