-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated HCP Packer datasources and attributes #791
Conversation
@@ -14,6 +15,8 @@ import ( | |||
"github.com/hashicorp/terraform-provider-hcp/internal/clients/packerv2" | |||
) | |||
|
|||
var defaultPackerTimeout = time.Minute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this was moved here because it was previously defined in one of the removed datasources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
🛠️ Description
Removing deprecated HCP Packer data sources and attributes related to the old nomenclature. All of these had their replacement data source or attribute released back at the end of January.
🏗️ Acceptance tests
Output from acceptance testing: