Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated HCP Packer datasources and attributes #791

Merged
merged 6 commits into from
Mar 20, 2024

Conversation

sylviamoss
Copy link
Contributor

🛠️ Description

Removing deprecated HCP Packer data sources and attributes related to the old nomenclature. All of these had their replacement data source or attribute released back at the end of January.

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAcc.*PackerChannelAssignment -test.v'
==> Checking that code complies with gofmt requirements...
golangci-lint run --config ./golangci-config.yml 
TF_ACC=1 go test ./internal/... -v -run=TestAcc.*PackerChannelAssignment -test.v -timeout 360m -parallel=10
?       github.com/hashicorp/terraform-provider-hcp/internal/clients/iampolicy  [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/clients/packerv1   [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/clients/packerv2   [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider   [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/acctest   [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/customtypes       [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/modifiers [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer    [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils/testcheck        [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils/configbuilder    [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils  [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils/configbuilder/packerconfig       [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/testutils/testclient       [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/utils      [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/utils/location     [no test files]
?       github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/utils/base [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/clients    0.625s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/consul     0.203s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/hcpvalidator       0.441s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/input      0.313s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/iam       0.633s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/logstreaming      0.835s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/sources/artifact   1.284s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/packer/sources/version    1.114s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/resourcemanager   0.876s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/vaultsecrets      0.920s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/waypoint  1.275s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/webhook   1.492s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider/webhook/validator 0.718s [no tests to run]
=== RUN   TestAccPackerChannelAssignment_SimpleSetUnset
=== PAUSE TestAccPackerChannelAssignment_SimpleSetUnset
=== RUN   TestAccPackerChannelAssignment_AssignLatest
=== PAUSE TestAccPackerChannelAssignment_AssignLatest
=== RUN   TestAccPackerChannelAssignment_InvalidInputs
=== PAUSE TestAccPackerChannelAssignment_InvalidInputs
=== RUN   TestAccPackerChannelAssignment_CreateFailsWhenPreassigned
=== PAUSE TestAccPackerChannelAssignment_CreateFailsWhenPreassigned
=== RUN   TestAccPackerChannelAssignment_HCPManagedChannelErrors
=== PAUSE TestAccPackerChannelAssignment_HCPManagedChannelErrors
=== RUN   TestAccPackerChannelAssignment_EnforceNull
=== PAUSE TestAccPackerChannelAssignment_EnforceNull
=== CONT  TestAccPackerChannelAssignment_SimpleSetUnset
=== CONT  TestAccPackerChannelAssignment_CreateFailsWhenPreassigned
=== CONT  TestAccPackerChannelAssignment_AssignLatest
=== CONT  TestAccPackerChannelAssignment_InvalidInputs
=== CONT  TestAccPackerChannelAssignment_EnforceNull
=== CONT  TestAccPackerChannelAssignment_HCPManagedChannelErrors
--- PASS: TestAccPackerChannelAssignment_InvalidInputs (5.92s)
--- PASS: TestAccPackerChannelAssignment_HCPManagedChannelErrors (6.87s)
--- PASS: TestAccPackerChannelAssignment_CreateFailsWhenPreassigned (10.78s)
--- PASS: TestAccPackerChannelAssignment_EnforceNull (15.14s)
--- PASS: TestAccPackerChannelAssignment_SimpleSetUnset (16.56s)
--- PASS: TestAccPackerChannelAssignment_AssignLatest (18.02s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/providersdkv2      19.683s
...

@sylviamoss sylviamoss requested review from a team as code owners March 19, 2024 13:31
@sylviamoss sylviamoss changed the title Remove deprecated datasources attr Remove deprecated HCP Packer datasources and attributes Mar 19, 2024
@@ -14,6 +15,8 @@ import (
"github.com/hashicorp/terraform-provider-hcp/internal/clients/packerv2"
)

var defaultPackerTimeout = time.Minute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this was moved here because it was previously defined in one of the removed datasources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sylviamoss sylviamoss merged commit 303cfdc into main Mar 20, 2024
6 checks passed
@sylviamoss sylviamoss deleted the hpr-1518_remove_deprecated_datasources_attr branch March 20, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants