Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data source for packer registry #169
Data source for packer registry #169
Changes from 16 commits
5d91f37
e594afe
d381e02
9092ab2
d1867aa
3be9aca
7500dac
76bb967
bfe5099
1d3ed90
ff12e1e
66254ef
7afcdc7
8063413
be602f5
4dbb8bd
5cb2338
2db3cba
aa1be36
9874c8b
9e5728f
63d18cf
630880f
280ff02
9d00c67
ca6d036
7397f83
73d79d8
5512bac
31760fc
6707024
f4bcb91
3c2cb91
34b5f2c
7ae2cd9
14ad128
b835c06
d9eacad
6343175
cdc0c02
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any plans to make
bucket
andchannel
resources so this can all be managed by TF?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooo, could make this a shared helper 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll maybe do that in another PR, if time !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this test upserts some test data that TF doesn't manage directly, we'll need an extra step to clean them up. You can add
CheckDestroy: testAccPackerCheckDestroy
here, then implement the CheckDestroy function to remove all the upserted data and verify the data source is deleted (peering example)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azr this has been implemented in #180 which @bcmdarroch has reviewed and approved. The change contain a few additional error checks, and a potential bug fix when requesting a channel that has not been assigned a complete iteration.
I confirmed the panic using the provider on an exiting channel with no assigned iteration, and confirmed that the fix errors as expected. Merging the changes as they are for now so that we can get this in. But please follow up on the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Wilken !