Data source for packer registry #169

azr · 2021-07-21T10:25:29Z

🛠️ Description

This add a new data source block that will display data from the Packer Registry.

⚠️ I also had to fix a few references for consul things after updating the dependency.

🚢 Release Note

Release note for CHANGELOG:

* provider: add data source for packer registry

🏗️ Acceptance tests

Are there any feature flags that are required to use this functionality? > Nope !
Have you added an acceptance test for the functionality being added?
Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAcc_dataSourcePacker'      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/... -v -run=TestAcc_dataSourcePacker -timeout 120m
?       github.com/hashicorp/terraform-provider-hcp/internal/clients    [no test files]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/consul     2.709s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/input      3.274s [no tests to run]
=== RUN   TestAcc_dataSourcePacker
--- PASS: TestAcc_dataSourcePacker (9.86s)
PASS
ok      github.com/hashicorp/terraform-provider-hcp/internal/provider   10.540s

...

…orp/terraform-provider-hcp into data_source_packer_registry

more ptr stuff

SwampDragons

This looks good to me, though I haven't had a chance to test it. How are resources for this provider normally documented? I don't see any doc elements added here, but it's possible they're generated somewhere else and I'm just missing context.

internal/provider/data_source_packer_image.go

bcmdarroch

Looking good! Had a few questions and comments. Also, you can generate docs by running go generate ./.... Not sure why the PR checks didn't catch that 💭

internal/clients/hvn_route.go

internal/provider/data_source_packer_image.go

remove `ID` reference, as this is a slug

nywilken

This looks really good.

This reverts commit 7500dac.

internal/provider/data_source_packer_image_iteration.go

Co-authored-by: Brenna Hewer-Darroch <[email protected]>

bcmdarroch

Looks good to me! This is definitely close. Just had an open question about the ID field.

I also wasn't able to run the acceptance test ([409] GetChannel default &{Code:10 Details:[] Error:error querying bucket from db Message:error querying bucket from db}), I'm guessing because it still needs a pre-config step that creates the image.

go.mod

internal/provider/data_source_packer_image_iteration.go

bcmdarroch · 2021-07-30T22:13:31Z

internal/provider/data_source_packer_image_iteration.go

+	return nil
+}
+
+func setLocationData(d *schema.ResourceData, loc *sharedmodels.HashicorpCloudLocationLocation) error {


Ooo, could make this a shared helper 👀

I'll maybe do that in another PR, if time !

Co-authored-by: Brenna Hewer-Darroch <[email protected]>

azr · 2021-08-03T09:51:42Z

Thanks for reviewing ! 🙂 I still need to make the docs page look good and to fix the acc tests.

…orp/terraform-provider-hcp into data_source_packer_registry

remote "id" part as it's already in there

This reverts commit 5512bac.

azr · 2021-08-03T14:50:07Z

Hello there, Acc tests are almost working, I just need to fix an endpoint on our end !

go.mod

to fix a weird 'Step 1/1 error: unsupported state format version: expected "0.1", got "0.2"' error

azr · 2021-08-04T12:37:24Z

🥳 Super cool, acc tests pass ! Are we good with docs ? 🙂

…gistry

v

azr · 2021-08-05T10:50:16Z

We're good with docs !

bcmdarroch

This is so close! Last step is to upsert one more dependency (channel) and then add a handler to clean up all the upserted dependencies.

bcmdarroch · 2021-08-05T20:00:42Z

internal/provider/data_source_packer_image_iteration.go

+		},
+		Schema: map[string]*schema.Schema{
+			// Required inputs
+			"bucket": {


Are there any plans to make bucket and channel resources so this can all be managed by TF?

bcmdarroch · 2021-08-05T20:03:32Z

internal/provider/data_source_packer_image_iteration_test.go

+					upsertBucket(t, bucket)
+					upsertIteration(t, bucket, fingerprint)
+					itID := getIterationIDFromFingerPrint(t, bucket, fingerprint)
+					upsertBuild(t, bucket, fingerprint, itID)


I've been getting an error when running this test:

{"error":"could not load the channel. something in the request is invalid. ","code":3,"message":"could not load the channel. something in the request is invalid. ","details":[]} 2021/08/05 12:05:49 [WARN] Got error running Terraform: exit status 1

I believe it's because the channel hasn't been upserted here.

@azr this issue has been address in #180 with the addition of the createChannel and updateChannel calls.

bcmdarroch · 2021-08-05T20:08:30Z

internal/provider/data_source_packer_image_iteration_test.go

+	resource.Test(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t, false) },
+		ProviderFactories: providerFactories,
+


Since this test upserts some test data that TF doesn't manage directly, we'll need an extra step to clean them up. You can add CheckDestroy: testAccPackerCheckDestroy here, then implement the CheckDestroy function to remove all the upserted data and verify the data source is deleted (peering example)

@azr this has been implemented in #180 which @bcmdarroch has reviewed and approved. The change contain a few additional error checks, and a potential bug fix when requesting a channel that has not been assigned a complete iteration.

I confirmed the panic using the provider on an exiting channel with no assigned iteration, and confirmed that the fix errors as expected. Merging the changes as they are for now so that we can get this in. But please follow up on the changes.

Thanks Wilken !

bcmdarroch

Just tested with the fixes in #180 and saw the acceptance test pass! 🎉 Let's get this in!

* Add CheckDestroy step for Packer Data Source Test This change adds a few new helper functions for deleting resources on the HCP Packer registry under tests. Test Results After Change ``` make testacc TESTARGS='-count=1 -run=TestAcc_dataSourcePacker' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/... -v -count=1 -run=TestAcc_dataSourcePacker -timeout 120m ? github.com/hashicorp/terraform-provider-hcp/internal/clients [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-hcp/internal/consul 0.172s [no tests to run] testing: warning: no tests to run PASS ok github.com/hashicorp/terraform-provider-hcp/internal/input 0.127s [no tests to run] === RUN TestAcc_dataSourcePacker --- PASS: TestAcc_dataSourcePacker (6.47s) PASS ok github.com/hashicorp/terraform-provider-hcp/internal/provider 6.815s ``` * Fix panic when requesting a channel that has no assigned iteration After change ``` data_source_packer_image_iteration_test.go:284: Step 1/1 error: Error running pre-apply refresh: exit status 1 Error: no iteration information found for the specified channel production with data.hcp_packer_image_iteration.alpine, on terraform_plugin_test.tf line 4, in data "hcp_packer_image_iteration" "alpine": 4: data "hcp_packer_image_iteration" "alpine" { --- FAIL: TestAcc_dataSourcePacker (2.68s) FAIL FAIL github.com/hashicorp/terraform-provider-hcp/internal/provider 3.246s FAIL make: *** [testacc] Error 1 ``` * Update error handling for resource creation This change adds a new updateChannel function to handle the updating of a test channel that may have been created in a previous run, but not cleaned up.

SwampDragons and others added 12 commits July 12, 2021 11:35

add file for packer registry

5d91f37

add packe registry to provider.go

e594afe

packer client

d381e02

WIP

9092ab2

Merge branch 'data_source_packer_registry' of ssh://github.com/hashic…

d1867aa

…orp/terraform-provider-hcp into data_source_packer_registry

flattenPackerBuildList

3be9aca

fix pointer type errors after dependency update

7500dac

more ptr stuff

Update data_source_packer_image.go

76bb967

add & run tests

bfe5099

Update data_source_packer_image.go

1d3ed90

it works !

ff12e1e

go mod tidy

66254ef

azr marked this pull request as ready for review July 21, 2021 16:09

azr requested review from a team as code owners July 21, 2021 16:09

azr requested a review from a team July 21, 2021 16:09

SwampDragons approved these changes Jul 26, 2021

View reviewed changes

internal/provider/data_source_packer_image.go Outdated Show resolved Hide resolved

bcmdarroch reviewed Jul 27, 2021

View reviewed changes

internal/clients/hvn_route.go Outdated Show resolved Hide resolved

internal/provider/data_source_packer_image.go Outdated Show resolved Hide resolved

internal/provider/data_source_packer_image.go Outdated Show resolved Hide resolved

azr marked this pull request as draft July 27, 2021 11:48

azr mentioned this pull request Jul 27, 2021

Packer service client sdk hashicorp/hcp-sdk-go#29

Merged

2 tasks

This comment has been minimized.

Sign in to view

azr added 2 commits July 27, 2021 14:04

fix description for bucket

7afcdc7

remove `ID` reference, as this is a slug

nest iteration stuff under iteration

8063413

nywilken approved these changes Jul 27, 2021

View reviewed changes

azr force-pushed the data_source_packer_registry branch from 2dfed66 to 8063413 Compare July 27, 2021 15:06

azr added 2 commits July 27, 2021 17:08

start showing builds & hcp_packer_image -> hcp_packer_image_iteration

be602f5

Revert "fix pointer type errors after dependency update"

4dbb8bd

This reverts commit 7500dac.

bcmdarroch reviewed Jul 27, 2021

View reviewed changes

internal/provider/data_source_packer_image_iteration.go Outdated Show resolved Hide resolved

bcmdarroch reviewed Jul 27, 2021

View reviewed changes

internal/provider/data_source_packer_image_iteration.go Outdated Show resolved Hide resolved

Update internal/provider/data_source_packer_image_iteration.go

5cb2338

Co-authored-by: Brenna Hewer-Darroch <[email protected]>

bcmdarroch reviewed Jul 30, 2021

View reviewed changes

azr and others added 2 commits August 3, 2021 11:42

go get github.com/hashicorp/[email protected] && go mod tidy

630880f

Update internal/provider/data_source_packer_image_iteration.go

280ff02

Co-authored-by: Brenna Hewer-Darroch <[email protected]>

azr added 9 commits August 3, 2021 13:43

Create data-source.tf

9d00c67

Create packer_image_iteration.md.tmpl

ca6d036

Update packer_image_iteration.md

7397f83

Merge branch 'data_source_packer_registry' of ssh://github.com/hashic…

73d79d8

…orp/terraform-provider-hcp into data_source_packer_registry

Delete data_source_packer_image_iteration_test.go

5512bac

Update data_source_packer_image_iteration.go

31760fc

remote "id" part as it's already in there

Update packer_image_iteration.md

6707024

Revert "Delete data_source_packer_image_iteration_test.go"

f4bcb91

This reverts commit 5512bac.

auto-upsert acc tests data

3c2cb91

bcmdarroch reviewed Aug 3, 2021

View reviewed changes

go.mod Outdated Show resolved Hide resolved

azr added 4 commits August 4, 2021 10:12

go get github.com/hashicorp/[email protected] && tidy

34b5f2c

Update data_source_packer_image_iteration.go

7ae2cd9

Update data_source_packer_image_iteration_test.go

14ad128

go get -u github.com/hashicorp/terraform-json

b835c06

to fix a weird 'Step 1/1 error: unsupported state format version: expected "0.1", got "0.2"' error

azr force-pushed the data_source_packer_registry branch from 7c25fed to b835c06 Compare August 4, 2021 12:45

azr added 2 commits August 4, 2021 14:46

Merge remote-tracking branch 'origin/main' into data_source_packer_re…

d9eacad

…gistry

manually fix docs

6343175

v

azr force-pushed the data_source_packer_registry branch from cc8011c to 6343175 Compare August 5, 2021 10:49

bcmdarroch reviewed Aug 5, 2021

View reviewed changes

bcmdarroch approved these changes Aug 6, 2021

View reviewed changes

nywilken merged commit 4146ea6 into main Aug 6, 2021

nywilken deleted the data_source_packer_registry branch August 6, 2021 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Data source for packer registry #169

Data source for packer registry #169

azr commented Jul 21, 2021 •

edited

Loading

SwampDragons left a comment

bcmdarroch left a comment

This comment has been minimized.

nywilken left a comment

bcmdarroch left a comment

bcmdarroch Jul 30, 2021

azr Aug 4, 2021

azr commented Aug 3, 2021 •

edited

Loading

azr commented Aug 3, 2021

azr commented Aug 4, 2021

azr commented Aug 5, 2021

bcmdarroch left a comment

bcmdarroch Aug 5, 2021

bcmdarroch Aug 5, 2021

nywilken Aug 6, 2021

bcmdarroch Aug 5, 2021

nywilken Aug 6, 2021

azr Aug 9, 2021

bcmdarroch left a comment

Data source for packer registry #169

Data source for packer registry #169

Conversation

azr commented Jul 21, 2021 • edited Loading

🛠️ Description

🚢 Release Note

🏗️ Acceptance tests

SwampDragons left a comment

Choose a reason for hiding this comment

bcmdarroch left a comment

Choose a reason for hiding this comment

This comment has been minimized.

nywilken left a comment

Choose a reason for hiding this comment

bcmdarroch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azr commented Aug 3, 2021 • edited Loading

azr commented Aug 3, 2021

azr commented Aug 4, 2021

azr commented Aug 5, 2021

bcmdarroch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bcmdarroch left a comment

Choose a reason for hiding this comment

azr commented Jul 21, 2021 •

edited

Loading

azr commented Aug 3, 2021 •

edited

Loading