Azure Rotating Secrets Changes #1143

murali-partha · 2024-11-22T10:54:39Z

🛠️ Description

Added hcp_vault_secrets_integration_azureresource and modified hcp_vault_secrets_rotating_secret to support Azure Application Password.

🏗️ Acceptance tests

Are there any feature flags that are required to use this functionality?
Have you added an acceptance test for the functionality being added?
Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

hashicorp-cla-app · 2024-11-22T10:54:53Z

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

maxcoulombe · 2024-12-02T15:42:15Z

docs/resources/vault_secrets_rotating_secret.md

@@ -82,6 +94,7 @@ resource "hcp_vault_secrets_rotating_secret" "example_confluent" {
 ### Optional

 - `aws_access_keys` (Attributes) AWS configuration to manage the access key rotation for the given IAM user. Required if `secret_provider` is `aws`. (see [below for nested schema](#nestedatt--aws_access_keys))
+- `azure_application_password_params` (Attributes) Azure configuration to manage the application password rotation for the given application. Required if `secret_provider` is `confluent`. (see [below for nested schema](#nestedatt--azure_application_password_params))


Suggested change

- `azure_application_password_params` (Attributes) Azure configuration to manage the application password rotation for the given application. Required if `secret_provider` is `confluent`. (see [below for nested schema](#nestedatt--azure_application_password_params))

- `azure_application_password` (Attributes) Azure configuration to manage the application password rotation for the given application. Required if `secret_provider` is `azure`. (see [below for nested schema](#nestedatt--azure_application_password_params))

The param suffix feels redundant and the other credential types did not add it. There is a Confluent copy-paste leftover.

Whoops I think this is the generated code. Nvm the suggestion but the comment are relevant to the resource schema.

Thanks for noticing this. Updated.

examples/resources/hcp_vault_secrets_integration_azure/import.sh

examples/resources/hcp_vault_secrets_integration_azure/resource.tf

maxcoulombe · 2024-12-02T15:52:29Z

internal/provider/vaultsecrets/resource_vault_secrets_rotating_secret.go

@@ -206,6 +213,29 @@ func (r *resourceVaultSecretsRotatingSecret) Schema(_ context.Context, _ resourc
 				exactlyOneRotatingSecretTypeFieldsValidator,
 			},
 		},
+		"azure_application_password_params": schema.SingleNestedAttribute{


I'd remove the params suffix to align with the other credential types

Agreed. Changed it.

internal/provider/vaultsecrets/resource_vault_secrets_rotating_secret.go

maxcoulombe

Looks good, couple of nits or copy-paste leftovers but the bulk of it looks solid.

…_secret.go Co-authored-by: Max Coulombe <[email protected]>

pierluc-codes · 2024-12-03T17:50:24Z

docs/resources/vault_secrets_integration_azure.md

+
+### Required
+
+- `capabilities` (Set of String) Capabilities enabled for the integration. See the Vault Secrets documentation for the list of supported capabilities per provider.


as dicussed in a preivous PR, i didnt foudn this documentaiton

This is a standard message across all integrations. AWS, GCP, Twilio

Do you think linking users to our docs' landing page would be helpful?

https://developer.hashicorp.com/hcp/docs/vault-secrets

I could do that, the docs page doesn't directly talk about the capabilities option though. Another approach would be to list the options [ 'sync', 'rotation', 'dynamic'] in the same string. I am fine with adding either of these.

Note: This is a generated file, hence making this change will affect all the integration doc files where capabilities is listed.

pierluc-codes · 2024-12-03T17:51:04Z

docs/resources/vault_secrets_integration_azure.md

+page_title: "hcp_vault_secrets_integration_azure Resource - terraform-provider-hcp"
+subcategory: ""
+description: |-
+  The Vault Secrets Azure integration resource manages an Azure integration.


This feel incomplete.

Similar to the above comment, this is a standard message across integrations.

pierluc-codes · 2024-12-03T17:51:38Z

docs/resources/vault_secrets_integration_azure.md

+
+# hcp_vault_secrets_integration_azure (Resource)
+
+The Vault Secrets Azure integration resource manages an Azure integration.


This feel incomplete.

Same as above.

murali-partha added 2 commits November 22, 2024 15:47

adding azure integration for rotating secrets changes

6a52ca4

adding test file

9f8a315

murali-partha added 5 commits November 22, 2024 16:27

adding changelog file

a8790a6

updateing validation

8e10031

fixing test failures

2d5d7e0

docs

709b74a

minor changes

17eef45

murali-partha marked this pull request as ready for review November 25, 2024 16:40

murali-partha requested review from a team as code owners November 25, 2024 16:40

maxcoulombe reviewed Dec 2, 2024

View reviewed changes

examples/resources/hcp_vault_secrets_integration_azure/import.sh Outdated Show resolved Hide resolved

maxcoulombe reviewed Dec 2, 2024

View reviewed changes

examples/resources/hcp_vault_secrets_integration_azure/resource.tf Show resolved Hide resolved

maxcoulombe reviewed Dec 2, 2024

View reviewed changes

internal/provider/vaultsecrets/resource_vault_secrets_rotating_secret.go Outdated Show resolved Hide resolved

maxcoulombe previously approved these changes Dec 2, 2024

View reviewed changes

Update internal/provider/vaultsecrets/resource_vault_secrets_rotating…

e8ff325

…_secret.go Co-authored-by: Max Coulombe <[email protected]>

murali-partha dismissed maxcoulombe’s stale review via e8ff325 December 2, 2024 15:55

addressing review comments

4639f6a

pierluc-codes reviewed Dec 3, 2024

View reviewed changes

murali-partha added 2 commits December 4, 2024 21:10

addressing review comments

8b47858

addressing review comments

67040f0

pierluc-codes approved these changes Dec 4, 2024

View reviewed changes

maxcoulombe approved these changes Dec 5, 2024

View reviewed changes

murali-partha merged commit 00e266b into main Dec 5, 2024
5 of 6 checks passed

murali-partha deleted the azure-rotating-secrets branch December 5, 2024 17:28

dhuckins mentioned this pull request Dec 9, 2024

hvs pg rotating secret #1130

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Azure Rotating Secrets Changes #1143

Azure Rotating Secrets Changes #1143

murali-partha commented Nov 22, 2024 •

edited

Loading

hashicorp-cla-app bot commented Nov 22, 2024

maxcoulombe Dec 2, 2024

maxcoulombe Dec 2, 2024

murali-partha Dec 4, 2024

maxcoulombe Dec 2, 2024

murali-partha Dec 4, 2024

maxcoulombe left a comment

pierluc-codes Dec 3, 2024

murali-partha Dec 4, 2024 •

edited

Loading

maxcoulombe Dec 5, 2024

murali-partha Dec 5, 2024 •

edited

Loading

pierluc-codes Dec 3, 2024

murali-partha Dec 4, 2024

pierluc-codes Dec 3, 2024

murali-partha Dec 4, 2024

	- `azure_application_password_params` (Attributes) Azure configuration to manage the application password rotation for the given application. Required if `secret_provider` is `confluent`. (see [below for nested schema](#nestedatt--azure_application_password_params))
	- `azure_application_password` (Attributes) Azure configuration to manage the application password rotation for the given application. Required if `secret_provider` is `azure`. (see [below for nested schema](#nestedatt--azure_application_password_params))


		### Required

		- `capabilities` (Set of String) Capabilities enabled for the integration. See the Vault Secrets documentation for the list of supported capabilities per provider.


		# hcp_vault_secrets_integration_azure (Resource)

		The Vault Secrets Azure integration resource manages an Azure integration.

Azure Rotating Secrets Changes #1143

Azure Rotating Secrets Changes #1143

Conversation

murali-partha commented Nov 22, 2024 • edited Loading

🛠️ Description

🏗️ Acceptance tests

hashicorp-cla-app bot commented Nov 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maxcoulombe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

murali-partha Dec 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

murali-partha Dec 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

murali-partha commented Nov 22, 2024 •

edited

Loading

murali-partha Dec 4, 2024 •

edited

Loading

murali-partha Dec 5, 2024 •

edited

Loading