hvs pg rotating secret #1130
hvs pg rotating secret #1130
Conversation
|
|
||
| // Inner API-compatible models derived from the Terraform fields | ||
| capabilities []*secretmodels.Secrets20231128Capability `tfsdk:"-"` | ||
| staticCredentialDetails *secretmodels.Secrets20231128PostgresStaticCredentialsRequest `tfsdk:"-"` |
There was a problem hiding this comment.
We may need to add a gateway pool ID here as well
There was a problem hiding this comment.
should we introduce that separately (in a diff PR) or here?
are (should) gateways be added to the tf provider?
There was a problem hiding this comment.
I'd opt for here since a postgres integration is not particularly useful without a gateway
…rovider-hcp into dh/hvs-pg-rotating
…to dh/hvs-pg-rotating
…to dh/hvs-pg-rotating
| Import is supported using the following syntax: | ||
|
|
||
| ```shell | ||
| terraform import hcp_vault_secrets_integration_postgres.example my-postgres-1 |
There was a problem hiding this comment.
Please clarify my-postgres-1
There was a problem hiding this comment.
| @@ -0,0 +1,57 @@ | |||
| --- | |||
| # generated by https://github.com/hashicorp/terraform-plugin-docs | |||
| page_title: "hcp_vault_secrets_integration_postgres Resource - terraform-provider-hcp" | |||
There was a problem hiding this comment.
should it be named postgresql?
There was a problem hiding this comment.
no, postgres is correct
|
|
||
| ### Optional | ||
|
|
||
| - `project_id` (String) HCP project ID that owns the HCP Vault Secrets integration. Inferred from the provider configuration if omitted. |
There was a problem hiding this comment.
where this can be found?
There was a problem hiding this comment.
not sure what you mean (this is consistent with other docs for other providers)
see #1143
|
|
||
| Required: | ||
|
|
||
| - `connection_string` (String, Sensitive) Connection string (DSN) for the Postgres database. |
There was a problem hiding this comment.
where this can be found?
|
|
||
| ### Required | ||
|
|
||
| - `capabilities` (Set of String) Capabilities enabled for the integration. See the Vault Secrets documentation for the list of supported capabilities per provider. |
There was a problem hiding this comment.
I didn't find the matching documentation
internal/provider/vaultsecrets/resource_vault_secrets_integration_postgres.go
Outdated
Show resolved
Hide resolved
|
|
||
| func (r *resourceVaultSecretsIntegrationPostgres) Metadata(_ context.Context, req resource.MetadataRequest, resp *resource.MetadataResponse) { | ||
| resp.TypeName = req.ProviderTypeName + "_vault_secrets_integration_postgres" | ||
| } |
There was a problem hiding this comment.
@dhuckins there is an initiative on the Ecosystem side to make the integration management API more generic and reduce the amount of provider-specific code necessary to build and maintain for new integrations. We,ll move closer to how the rotating & dynamic secret resources are architected.
We will shortly implement a hcp_vault_secrets_integration resource (ticket) to support all providers and deprecate the provider-specific resources. We should not introduce new provider-specific integration resources e.i. hcp_vault_secrets_integration_{provider}.
We should wait a bit and support postgres only via the hcp_vault_secrets_integration resource. Sorry if this is last minute and requires work on this PR. If there are any questions please reach out to the team on #team-hvs-ecosystem.
There was a problem hiding this comment.
will close this then.
have a gateway PR that I can put up
add new postgres integration resource and add postgres rotating secret
HV-1704
HV-1707
🛠️ Description
🏗️ Acceptance tests
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX' ...