Rotating secret resource implementation #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcoulombe
changed the base branch from
main
to
vault-29950/dynamic-secret-resource
maxcoulombe
force-pushed
the
vault-29950/rotating-secret-resource
branch
from
918507b
to
f45ec8c
Compare
* lint * lint * tidy imports * rename
maxcoulombe
force-pushed
the
vault-29950/rotating-secret-resource
branch
from
2e50904
to
b33d732
Compare
…otating-secret-resource
…otating-secret-resource
…otating-secret-resource
austingebauer
approved these changes
Sep 24, 2024
| - `integration_name` (String) The Vault Secrets integration name with the capability to manage the secret's lifecycle. | ||
| - `name` (String) The Vault Secrets secret name. | ||
| - `rotation_policy_name` (String) Name of the rotation policy that governs the rotation of the secret. | ||
| - `secret_provider` (String) The third party platform the dynamic credentials give access to. One of `aws` or `gcp`. |
There was a problem hiding this comment.
nit: could drop "dynamic" here since these fields are shared between both capabilities
There was a problem hiding this comment.
My bad I missed that comment. I'll fix it in a follow-up.
jasonpilz
approved these changes
Sep 24, 2024
maxcoulombe
merged commit dfd1361
into
vault-29950/dynamic-secret-resource
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Added the Vault Secrets rotating secret resource.
Using the interfaces and abstractions introduced in #1097
🏗️ Acceptance tests
Output from acceptance testing: