Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic secret resource implementation #1097

Merged
merged 15 commits into from
Sep 24, 2024
Merged

Dynamic secret resource implementation #1097

merged 15 commits into from
Sep 24, 2024

Conversation

maxcoulombe
Copy link
Contributor

@maxcoulombe maxcoulombe commented Sep 19, 2024 •
edited
Loading

🛠️ Description

Added the Vault Secrets dynamic secret resource.
Created some interfaces and abstractions so additional dynamic and rotating secrets are easier to implement.

🏗️ Acceptance tests

  • [-] Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

Screenshot from 2024-09-20 14-39-19

...

@maxcoulombe maxcoulombe marked this pull request as ready for review September 20, 2024 19:03
@maxcoulombe maxcoulombe requested review from a team as code owners September 20, 2024 19:03
@maxcoulombe maxcoulombe mentioned this pull request Sep 23, 2024
Merged
2 tasks
austingebauer
austingebauer approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tried a bunch of different lifecycle/modifications and couldn't break it 👍

internal/provider/vaultsecrets/dynamic_secret_aws.go
"github.com/hashicorp/terraform-provider-hcp/internal/clients"
)

var _ dynamicSecret = &awsDynamicSecret{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, like the interface pattern for adding new dynamic secret providers.

examples/resources/hcp_vault_secrets_dynamic_secret/resource.tf Outdated Show resolved Hide resolved
internal/provider/vaultsecrets/vault_secrets_utils.go Outdated Show resolved Hide resolved
internal/provider/vaultsecrets/vault_secrets_utils.go Outdated Show resolved Hide resolved
@maxcoulombe maxcoulombe merged commit 34b9c15 into main Sep 24, 2024
6 checks passed
@maxcoulombe maxcoulombe deleted the vault-29950/dynamic-secret-resource branch September 24, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austingebauer austingebauer austingebauer approved these changes

@jasonpilz jasonpilz jasonpilz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxcoulombe @jasonpilz @austingebauer