Enable to specify ip_address in resource_compute_rooter_peer #9816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Because this file is generated via our code generation tool (https://github.com/GoogleCloudPlatform/magic-modules) I've upstreamed this there. I'll close this and let the code generation tool take over managing this Thanks for bringing up this fix! Please let me know if it doesn't work for you after that change gets in |
This was referenced Aug 25, 2021
|
Thanks! |
toshitanian
deleted the
compute_rooter_peer_enable_to_specify_ip_address
branch
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #9815
Enabled to specify
ip_addressproperty ofresource_compute_rooter_peerwhich now is always computed.This is compatible with the previous one and not breaking change.