Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting ip_address of bgp router peer #5098

Merged

Conversation

slevenick
Copy link
Contributor

Upstreams: hashicorp/terraform-provider-google#9816

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: allowed setting `ip_address` field of `google_compute_router_peer`

@google-cla google-cla bot added the cla: yes label Aug 16, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 28 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 5 files changed, 30 insertions(+), 13 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRouterPeer_basic|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201381

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_enable Please fix these to complete your PR

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 29 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 3 files changed, 29 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@slevenick
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 29 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 3 files changed, 29 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

1 similar comment
@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRouterPeer_enable You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201568

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccComputeRouterPeer_enable Please fix these to complete your PR

@c2thorn
Copy link
Member

c2thorn commented Aug 18, 2021

Interesting how the test failed. Could google_compute_vpn_tunnel be eventually consistent?

@c2thorn
Copy link
Member

c2thorn commented Aug 18, 2021

/gcbrun

@c2thorn c2thorn self-requested a review August 18, 2021 21:15
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 29 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 3 files changed, 29 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

2 similar comments
@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComposerEnvironment_update|TestAccComposerEnvironment_withSoftwareConfig|TestAccComputeRouterPeer_basic|TestAccComputeRouterPeer_enable You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201784

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccComposerEnvironment_withSoftwareConfig|TestAccComposerEnvironment_update Please fix these to complete your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants