Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pubsubConfig and webhookConfig support to the cloud build resource. #9541

Conversation

modular-magician
Copy link
Collaborator

Google have API documentation to create a pub/sub and webhook trigger in the cloud build resource, but, the terraform google provider doesn't. I have updated the terraform resource to add that support.

Fixes #8692, #9189

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudbuild: Added `pubsub_config` and `webhook_config` parameter to `google_cloudbuild_trigger`.

Derived from GoogleCloudPlatform/magic-modules#4931

@modular-magician modular-magician merged commit 2854a21 into hashicorp:master Jul 9, 2021
@the4thamigo-uk
Copy link

I cant get this to work when I have a pubsub trigger that builds a branch in github and because of the validation I cannot specify any of the git parameters either. Secondly, the pubsub topic is not displayed in the cloud console, am I doing something wrong or is this not fully supported?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2021
@modular-magician modular-magician deleted the downstream-pr-1baf42405fb910c2717177abb9b21dd8f9de22bd branch November 16, 2024 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for pub/sub invoked builds to google_cloudbuild_trigger
2 participants