Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pub/sub invoked builds to google_cloudbuild_trigger #8692

Comments

@bruno-morel
Copy link

bruno-morel commented Mar 15, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

This is an adjacent feature to the manual trigger (#8374)
You are able to create triggers in GCP console that are started on pub/sub events.
https://cloud.google.com/build/docs/automating-builds/create-pubsub-triggers#gcloud

Same would be nice to have supported with google_cloudbuild_trigger

New or Affected Resource(s)

  • google_XXXXX

Potential Terraform Configuration

google_cloudbuild_trigger

I believe it should be another Object inside the trigger properties that would be mutually exclusive to the other Trigger objects

References

#8374

@maqiuyujoyce
Copy link

I believe the Pub/Sub trigger is supported by the pubsubConfig field in the BuildTrigger defined here.

@tonybenchsci
Copy link

Any updates on when this might be supported?

1 similar comment
@javimoya
Copy link

javimoya commented Jun 2, 2021

Any updates on when this might be supported?

@al-dann
Copy link

al-dann commented Jun 10, 2021

and we need to take into account that the repository can be GitHub as well as Google Cloud Repository

@iamsumit
Copy link

I have raise a pull request to add the support. Can anyone please review this?

@github-actions
Copy link

github-actions bot commented Aug 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.