Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for pubsubConfig and webhookConfig trigger in the cloudbuild resource. #9386

Closed
wants to merge 2 commits into from
Closed

Added support for pubsubConfig and webhookConfig trigger in the cloudbuild resource. #9386

wants to merge 2 commits into from

Conversation

iamsumit
Copy link

@iamsumit iamsumit commented Jun 17, 2021

Google have API documentation to create a pub/sub and webhook trigger in the cloud build resource, but, the terraform google provider doesn't. I have updated the terraform resource to add that support.

There is an issue in creating the pub/sub trigger using rest API and that seems a bug in Google Cloud API. When we create the pub/sub trigger using rest API and edit the trigger, it looks like this:

configedit

If I update the cloud build manually and check the get response for the cloud build, there is no difference in the response and UI shows the configuration checked properly. We already discussed this with the product manager in Google and it seems there is a bug in Google.

@megan07 megan07 requested a review from rileykarson June 18, 2021 19:18
@iamsumit
Copy link
Author

The failing log says: 2021-06-18T19:15:29.2195766Z Can't find any online and idle self-hosted runner in current repository that matches the required labels: 'ubuntu-latest'

I am not sure if this is anything I am missing or there was some system issue. Can anyone please confirm?

@iamsumit iamsumit changed the title Added support for pubsubConfig trigger in the cloudbuild resource. Added support for pubsubConfig and webhookConfig trigger in the cloudbuild resource. Jun 29, 2021
@iamsumit
Copy link
Author

@megan07 @rileykarson We discussed about the missing webhookConfig support with the product manager in Google. It turns out that only documentation was missing which has been updated. I have added the support for webhookConfig in this PR only.

@rileykarson
Copy link
Collaborator

Hey @iamsumit! This file is generated by Magic Modules which means we're unable to accept contributions made directly against this repository. Instead, can you edit it under this directory?

MM's repo has a README with basic contribution instructions included. You can refer to similar fields in api.yaml and terraform.yaml to configure the field, and add your test to https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/third_party/terraform/tests/resource_cloudbuild_trigger_test.go so that this repo + google-beta are updated.

@iamsumit
Copy link
Author

@rileykarson That is so cool. Thank you. I have raised a PR: GoogleCloudPlatform/magic-modules#4931

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants