Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made deletion of all budget filter projects be recognized #8990

Conversation

modular-magician
Copy link
Collaborator

Resolved #8888.

In order to test that this was working properly, I also had to get imports working. This resource was made GA in GoogleCloudPlatform/magic-modules#4273; imports had apparently not been working properly at the time, and were disabled.

I believe this addresses the issues & allows importing to work as expected. I am a little paranoid that changing the import logic would result in the resources not being recognized from state, but I think it should be fine?

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

billingbudget: Added support for import of `google_billing_budget`

Derived from GoogleCloudPlatform/magic-modules#4731

…4731)

* Enabled imports for billing budget

* Made updates of filter projects get recognized during updates

* Added state migration function

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/xl label Apr 23, 2021
@modular-magician modular-magician merged commit 36ae51b into hashicorp:master Apr 23, 2021
@ghost
Copy link

ghost commented May 24, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 24, 2021
@modular-magician modular-magician deleted the downstream-pr-923daa459f8775b78297f4f60e19b5fc54e8657f branch November 17, 2024 02:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot clear projects from google_billing_budget
1 participant