-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made deletion of all budget filter projects be recognized #4731
Made deletion of all budget filter projects be recognized #4731
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 67 insertions(+), 27 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183806" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 198 insertions(+), 27 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183807" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 506 insertions(+), 27 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183809" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBillingBudget_billingBudgetBasicExample|TestAccBillingBudget_billingBudgetLastperiodExample|TestAccBillingBudget_billingBudgetFilterExample|TestAccBillingBudget_billingBudgetNotifyExample|TestAccComputeBackendService_internalLoadBalancing You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183811" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBillingBudget_billingBudgetUpdateRemoveFilter|TestAccBillingBudget_billingBudgetLastperiodExample|TestAccBillingBudget_billingBudgetBasicExample|TestAccBillingBudget_billingBudgetFilterExample|TestAccBillingBudget_billingBudgetNotifyExample|TestAccComputeBackendService_internalLoadBalancing You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183812" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBillingBudget_billingBudgetUpdateRemoveFilter|TestAccBillingBudget_billingBudgetBasicExample|TestAccBillingBudget_billingBudgetLastperiodExample|TestAccBillingBudget_billingBudgetFilterExample|TestAccBillingBudget_billingBudgetNotifyExample|TestAccComputeBackendService_internalLoadBalancing You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=183903" |
Resolved hashicorp/terraform-provider-google#8888.
In order to test that this was working properly, I also had to get imports working. This resource was made GA in #4273; imports had apparently not been working properly at the time, and were disabled.
I believe this addresses the issues & allows importing to work as expected. I am a little paranoid that changing the import logic would result in the resources not being recognized from state, but I think it should be fine?
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)