Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: artifact_registry_repository update always failing #8491

Conversation

modular-magician
Copy link
Collaborator

This PR fixes a bug where trying to update a google_artifact_registry_repository always failed due to the fact that the resource's Update logic was hitting the wrong API endpoint.

You can reproduce the issue by applying the following configs in succession:

Original:

resource "google_artifact_registry_repository" "my-repo" {
  provider = google-beta

  location = "us-central1"
  repository_id = "my-repository"
  description = "example docker repository"
  format = "DOCKER"
}

New:

resource "google_artifact_registry_repository" "my-repo" {
  provider = google-beta

  location = "us-central1"
  repository_id = "my-repository"
  description = "example docker repository 2"
  format = "DOCKER"
}

Related bugs (with details on impact and priority):

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

artifactregistry: fixed issue where updating `google_artifact_registry_repository` always failed

Derived from GoogleCloudPlatform/magic-modules#4482

…p#4482)

This fixes a bug where trying to update an artifact_registry_repository
always failed due to the fact that the resource's Update logic was
hitting the wrong API endpoint.

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/xs label Feb 17, 2021
@modular-magician modular-magician merged commit 6a17c84 into hashicorp:master Feb 17, 2021
@ghost
Copy link

ghost commented Mar 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2021
@modular-magician modular-magician deleted the downstream-pr-55a0431cf2b23a8dcc90f1fe044cf4825964c1d8 branch November 17, 2024 01:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant